[mlpack] [mlpack/mlpack] faster build times (#841)
Ryan Curtin
notifications at github.com
Thu Dec 22 23:12:35 EST 2016
I merged from master with
```
git remote add upstream https://github.com/mlpack/mlpack.git
git fetch upstream
git merge upstream/master
```
and to resolve the conflict with `spherical_kernel.hpp` I changed the includes on that file to just `#include <mlpack/prereqs.hpp>` and this works for a compile. The boost header isn't necessary anymore---when I went through a few weeks back to try and accelerate compile time a little, I was able to just use `std::tgamma()` instead, so that header is no longer necessary.
Maybe the problem you are seeing is a result of old compile artifacts or something and the build directory needs to be cleaned? If you can reproduce it, let me know what version of Boost so I can try and reproduce also.
When I do some timing comparisons, making just the core library takes 4m55s of user time instead of 6m21s, a nice improvement. :)
The real speed killer, I think, is all of the boost headers. I have a dream of managing to un-include any boost headers (including boost serialization) from any file that isn't directly using boost functionality, and I've made some steps in that direction, but it's difficult. Anyway, this is a nice step.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/mlpack/mlpack/pull/841#issuecomment-268938271
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://knife.lugatgt.org/pipermail/mlpack/attachments/20161222/78b693b8/attachment.html>
More information about the mlpack
mailing list