[mlpack] mlpack: Replacing boost::spirits

[Gopi Manohar Tatiraju]

Hey,

I made the changes as suggested by you, if possible have a look and let
me know where should I improve.

Regards,
Gopi

On Mon, Apr 12, 2021 at 3:06 AM Omar Shrit (Google Docs) <
comments-noreply at docs.google.com> wrote:

> Omar Shrit added comments and suggestions to the following document
> mlpack: Replacing boost::spirits
>
> <https://docs.google.com/document/d/1U2vYdnHwS3pP2hIhjDFY369bcORI-MHi2q_tvEUKpnE/edit?disco=AAAAIPv0Q5Q&ts=60736bf6&usp=comment_email_document&usp_dm=false>
> *New*
> 2 comments, 1 suggestion
> Comments
> We need to add armadillo’s csv parser(diskio_meat.hpp) with proper
> attribution wherever required into mlpack’s codebase. I suggest we don’t
> touch this file and create a new file to handle non-numeric data. The
> boost::spirit parser is contained completely in only two file:
> src/mlpack/core/data/load_csv.hpp src/mlpack/core/data/load_csv.cpp We can
> rewrite the above-mentioned two files to handle categorical data. As these
> files are already well implemented we can use the same interface.
> [image: User profile picture Omar Shrit] Omar ShritNew
> You can develop your ideas here, you can write them into paragraphs and
> then add tasks into bullet points
> Reply
> <Reply%20%3Cd+AORGpRcZkBi6ZhX-z438-5DpIxHiN8IOaUOAFDz4Ldjvo7X6ZjoZvWmruQHHX-UkcMHCJxLgCqXChktLvVkc2_PQbVxYC0Wxy5U-hNC8vaInoHiBMMQk2W83SeZbCTPHRcmC988C4iFH at docs.google.com%3E?subject=mlpack:%20Replacing%20boost::spirits>
> Open
> <https://docs.google.com/document/d/1U2vYdnHwS3pP2hIhjDFY369bcORI-MHi2q_tvEUKpnE/edit?disco=AAAAIPv0Q5E&usp=comment_email_discussion&usp_dm=false&ts=60736bf6>
> in the current file structure
> [image: User profile picture Omar Shrit] Omar ShritNew
> After this paragraph you can add more details about how you are going to
> represent the results, benchmark, and include the `Extra work` section in it
> Reply
> <Reply%20%3Cd+AORGpRe9M-wFzyjZ746lFIXaJyUnJ33CCXfLTTBrmNkmo_lgT-Oilk5zm2DVJU3-PvGALTzNpnDDibYUkJNusCCXpNJAucGzzqTX9MZZZt_OJLqgXuGx6LdDl9D815DAt1Qb1OCvEn7f at docs.google.com%3E?subject=mlpack:%20Replacing%20boost::spirits>
> Open
> <https://docs.google.com/document/d/1U2vYdnHwS3pP2hIhjDFY369bcORI-MHi2q_tvEUKpnE/edit?disco=AAAAIPv0Q5Q&usp=comment_email_discussion&usp_dm=false&ts=60736bf6>
> Suggestions
> [image: User profile picture Omar Shrit] Omar ShritNew
> Delete: “You can refer to issue #2646 to take a look there.”
> Reply
> <Reply%20%3Cd+AORGpRdZ_IFDJ2Z1c83M83kf2MCFoV2u4kmDwbKLHd3XaRxBzgHGh29TpeH7f8W89PyZ1mDmA3y3vW-0wyjNxhdQDDS8Eu-1ajAEm9VMkuojb7aiGHFxGoxV-wENOs8Au45-3Ec9dS_7 at docs.google.com%3E?subject=mlpack:%20Replacing%20boost::spirits>
> Open
> <https://docs.google.com/document/d/1U2vYdnHwS3pP2hIhjDFY369bcORI-MHi2q_tvEUKpnE/edit?disco=AAAAIPv0Q5A&usp=suggestion_email_discussion&usp_dm=false&ts=60736bf6>
>
> Google LLC, 1600 Amphitheatre Parkway, Mountain View, CA 94043, USA
>
> You have received this email because you are a participant in the updated
> discussion threads.Change what Google Docs sends you.
> <https://docs.google.com/document/u/118255091348362360280/docos/notify?ouid=118255091348362360280&id=1U2vYdnHwS3pP2hIhjDFY369bcORI-MHi2q_tvEUKpnE&title=mlpack:+Replacing+boost::spirits>You
> can not reply to this email.
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://knife.lugatgt.org/pipermail/mlpack/attachments/20210412/739ba1db/attachment-0001.htm>