[mlpack] [mlpack/mlpack] Initialise "success" variable to fix warnings (#840)

[Ryan Curtin]

rcurtin commented on this pull request.



> @@ -43,8 +43,6 @@ size_t RPlusTreeDescentHeuristic::ChooseDescentNode(TreeType* node,
         node->Child(bestIndex).Bound();
     bound |= node->Dataset().col(point);
 
-    success = true;
-

The change that you've made means that during this loop, `success` is not reinitialized to `true` each iteration.  So this introduces a bug.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/mlpack/mlpack/pull/840#pullrequestreview-14480154
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://knife.lugatgt.org/pipermail/mlpack/attachments/20161227/b15fa988/attachment.html>