[mlpack] [mlpack/mlpack] Faster build times (#842)

Ryan Curtin notifications at github.com
Fri Dec 23 15:50:55 EST 2016


```
C:\projects\mlpack\src\mlpack\core\math\lin_alg.cpp(233): error C2065: 'M_SQRT2': undeclared identifier [C:\projects\mlpack\build\src\mlpack\mlpack.vcxproj]
```

That's our offending line, but it's strange because `<mlpack/prereqs.hpp>` includes `<cmath>`.

http://stackoverflow.com/questions/6563810/m-pi-works-with-math-h-but-not-with-cmath-in-visual-studio

So, worth a shot is the explanation that something else is including `<cmath>` before `_USE_MATH_DEFINES` is defined.  A "shot in the dark" idea is to push that `<cmath>` include and `_USE_MATH_DEFINES` definition in `prereqs.hpp` up to be the first thing included.  If you like, push a change like that and let's see what AppVeyor thinks... :)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/mlpack/mlpack/pull/842#issuecomment-269044240
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://knife.lugatgt.org/pipermail/mlpack/attachments/20161223/62632aaa/attachment-0001.html>


More information about the mlpack mailing list