[mlpack] [mlpack/mlpack] adds GammaDistribution::Train(observations, probabilities) (#834)
Ryan Curtin
notifications at github.com
Fri Dec 23 15:44:31 EST 2016
Things look good to me minus the one comment about `BOOST_REQUIRE_CLOSE`. I'll probably refactor the tests very slightly after merge to try and use mlpack's existing RNGs instead of custom ones. You can add your name to `src/mlpack/core.hpp` and `COPYRIGHT.txt`. Let me know when you think this is ready to merge and I'll hit the button. Thanks again for taking the time to sort out the issues here.
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/mlpack/mlpack/pull/834#issuecomment-269043638
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://knife.lugatgt.org/pipermail/mlpack/attachments/20161223/71bb4031/attachment.html>
More information about the mlpack
mailing list