[mlpack] [mlpack/mlpack] cover tree optimization (#836)

[Ryan Curtin]

rcurtin commented on this pull request.



> @@ -876,6 +893,23 @@ CoverTree<MetricType, StatisticType, MatType, RootPointPolicy>::
       furthestDescendantDistance;
 }
 
+
+template<
+    typename MetricType,
+    typename StatisticType,
+    typename MatType,
+    typename RootPointPolicy
+>
+typename CoverTree<MetricType, StatisticType, MatType,
+    RootPointPolicy>::ElemType
+CoverTree<MetricType, StatisticType, MatType, RootPointPolicy>::
+    MaxDistance(const arma::vec& other, const ElemType bestDistance, bool forOverload)

I think the signature is wrong here, should this be `MaxDistanceForFast`?  (same with the other `MaxDistance` overload)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/mlpack/mlpack/pull/836#pullrequestreview-13846297
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://knife.lugatgt.org/pipermail/mlpack/attachments/20161220/71e1ed7e/attachment.html>