[mlpack] [mlpack/mlpack] Copy, move constructors and copy assignment operator added (#824)

Ryan Curtin notifications at github.com
Mon Dec 5 10:12:08 EST 2016


Hi there Piyush,

Thanks for the contribution.  Before we merge this, could I ask you to add some tests?  Take a look at the tests I wrote for the LSHSearch class's copy/move constructors and assignment operators:

https://github.com/rcurtin/mlpack/blob/bindings/src/mlpack/tests/lsh_test.cpp#L839

Thanks,

Ryan

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/mlpack/mlpack/pull/824#issuecomment-264879012
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://knife.lugatgt.org/pipermail/mlpack/attachments/20161205/7b0f8a31/attachment.html>


More information about the mlpack mailing list