[mlpack] #251

[Abhinav Pathak]

Hey,

1) In which all files do i need to change the definition/declaration of
BinarySpaceTree class to this form:
template<
    typename BoundType,
    typename MetricType,
    typename StatisticType,
    typename SplitType
>
class BinarySpaceTree;
I'm asking this because I'm getting a lot of random errors, which i'm not
able to debug as of now.



2) And can u pls clarify what exactly are: typename BoundType,
                                                       typename MetricType,
                                                       typename
StatisticType,

I'm slightly confused with the code architecture of BinarySpaceTree class




3) And also these functions:
void SplitNode(MatType& data, std::vector<size_t>& oldFromNew);

are declared in BinarySpaceTree class, should i remove them from this class
and put in the Mean Split class? Won't that cause some new errors?
And if suppose i do so, how would i use functions like bound.Diameter();
which are needed for the split and are present in the BinarySpaceTree class
?


4) And in this piece of code:
template<typename BoundType, typename StatisticType, typename MatType>
void BinarySpaceTree<BoundType, StatisticType, MatType>::SplitNode(
    MatType& data,
    std::vector<size_t>& oldFromNew)

why have <typename BoundType, typename StatisticType, typename MatType>
these been passed as template arguments ? I'm mean what the need of doing
so?


Thanks & Regards,
Abhinav Pathak


On Mon, Jan 20, 2014 at 9:37 AM, Ryan Curtin <gth671b at mail.gatech.edu>wrote:

> On Sun, Jan 19, 2014 at 09:39:13AM +0530, Abhinav Pathak wrote:
> > Hey,
> > Thanks for clarifying that.
> > If suppose i make a change in the binary_space_tree.hpp located at
> > mlpack-1.0.7/src/mlpack/core/tree/binary_space_tree,
> > how should i replace this file to that present in the builld/include
> > folder? And doing that is necessary right, because all the tests are run
> on
> > the files present inside the build folder, right?
> > And when i try replacing it with the file in build, it says i dont have
> > permissions to do that?
> > Can you specify what is the exact procedure to follow after i have made a
> > change in the file located in the src folder?
>
> Hello Abhinav,
>
> When you modify a file in src/, it will automatically be updated in
> build/include/ when you 'make mlpack_test' (or 'make mlpack').  If you
> are adding a new file, modify the CMakeLists.txt in that directory and
> add the new file to the list of sources.  Then when you type 'make
> mlpack_test' (or 'make mlpack') CMake will automatically update the
> files it needs to build and the file you added will be built into mlpack
> and copied to build/include/.
>
> Also, you should probably make your change against svn trunk, not mlpack
> 1.0.7.  You can check that out using subversion from the repository at
> http://svn.cc.gatech.edu/fastlab/mlpack/trunk/.
>
> Hope that helps.
>
> Ryan
>
> --
> Ryan Curtin    | "I don't really come from outer space."
> ryan at ratml.org |   - L.J. Washington
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.cc.gatech.edu/pipermail/mlpack/attachments/20140202/aa9c87fb/attachment-0002.html>